feat: Implemented VSCode lint problem matching #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrumpyMeow
changed the title
Merge branch 'feature/vscode-lint-problems' of https://github.com/GrumpyMeow/nx-console into feature/vscode-lint-problems
|
Can you elaborate on a few things?
We should probably have another solution that checks the executor or makes sure that the targets where created by the |
MaxKless
requested changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR i propose to have VSCode automatically take the output of NX-linting tasks and present the issues as VSCode problems.
This PR implements the matching at:
When running affected/many the output-style is automatically changed to display the found issues and allow for matching.
A known issue is that the default ESLint-formatter which is used by NX will report with absolute filepaths. The absolute filepaths might not align with the current environment as NX-caching does not take the root-folder in account.
In the future this feature might be extended to also work for Stylelint and others.
@MaxKless Would you like to check this PR?